首页 文章

使用Angular中的RxJs,我只需要完成在组件中创建的Observable吗?

提问于
浏览
2

基本上我还不太清楚Angular组件中反应代码的清理 . 以下规则是否正确且充分?

我对无功组件的规则:

  • on manual x.subscribe():

  • 如果使用x.takeUntil(...)或类似的构造,则无需手动清理

  • 如果在组件范围内调用x.complete(),则无需手动清理

  • else手动.unsubscribe()按需或在ngOnDestroy()

  • 关于模板的可观察性|异步:

  • 无需手动清理加上onPush兼容

  • 关于手动直接创建Observable,如新的Subject():
    在ngOnDestroy()中

  • manual .complete()从不关闭

  • 使用Observable.merge(...)等其他Observable进行手动创建:

  • 只要清理订阅,就不需要手动清理

我不确定最后一个要点 .

以下是根据这些规则重构的实际组件的完整示例,有人可以看到是否存在内存泄漏的危险吗?所有公共$ observable都通过模板中的异步管道进行订阅,因此我确信订阅已得到处理 . 用new创建的主题是手动清理的,所以应该没问题 . 我担心的部分是Observable.combineLatest(...)observables .

import { ChangeDetectionStrategy, Component, Input, OnDestroy } from '@angular/core';
import { Router } from '@angular/router';
import { DeliveryPointId } from 'app/bso';
import { BookmarkService } from 'app/general';
import { EAccess, EPermission, ReduxGetters, ReduxService } from 'app/redux';
import * as routing from 'app/routing';
import { BehaviorSubject, Observable } from 'app/rx';

@Component({
  selector: 'app-last-opened-workitems-widget',
  templateUrl: './last-opened-workitems-widget.component.html',
  changeDetection: ChangeDetectionStrategy.OnPush,
})
export class LastOpenedWorkitemsWidgetComponent implements OnDestroy {

  private readonly showPartners$ = new BehaviorSubject(true);
  private readonly showServices$ = new BehaviorSubject(true);
  private readonly showTens$ = new BehaviorSubject(true);
  private readonly showWorklist$ = new BehaviorSubject(true);

  @Input() set showItems(val: boolean) { this.showWorklist$.next(!!val); }
  @Input() set showPartners(val: boolean) { this.showPartners$.next(!!val); }
  @Input() set showProcesses(val: boolean) { this.showServices$.next(!!val); }
  @Input() set showTens(val: boolean) { this.showTens$.next(!!val); }

  constructor(
    private readonly redux: ReduxService,
    private readonly bookmarks: BookmarkService,
    private readonly router: Router,
  ) { }

  canPartners$ = this.redux.watch(ReduxGetters.userAccess).map(access => access[EPermission.Partner] >= EAccess.Read);
  canServices$ = this.redux.watch(ReduxGetters.userAccess).map(access => access[EPermission.Services] >= EAccess.Read);
  canTens$ = this.redux.watch(ReduxGetters.userAccess).map(access => access[EPermission.Tens] >= EAccess.Read);
  canWorklist$ = this.redux.watch(ReduxGetters.userAccess).map(access => access[EPermission.Worklist] >= EAccess.Read);

  lastItems$ = this.bookmarks.onLastOpenedWorkitems.map(ii => [...ii].reverse());
  lastPartners$ = this.bookmarks.onLastOpenedPartners.map(ii => [...ii].reverse());
  lastProcesses$ = this.bookmarks.onLastOpenedProcesses.map(ii => [...ii].reverse());
  lastTens$ = this.bookmarks.onLastOpenedTens.map(ii => [...ii].reverse());

  hasContentPartners$ = Observable
    .combineLatest(
      this.showPartners$.distinctUntilChanged(),
      this.canPartners$,
      this.lastPartners$.map(ii => ii.length > 0))
    .map(oks => oks.every(ii => ii));

  hasContentServices$ = Observable
    .combineLatest(
      this.showServices$.distinctUntilChanged(),
      this.canServices$,
      this.lastProcesses$.map(ii => ii.length > 0))
    .map(oks => oks.every(ii => ii));

  hasContentTens$ = Observable
    .combineLatest(
      this.showTens$.distinctUntilChanged(),
      this.canTens$,
      this.lastTens$.map(ii => ii.length > 0))
    .map(oks => oks.every(ii => ii));

  hasContentWorklist$ = Observable
    .combineLatest(
      this.showWorklist$.distinctUntilChanged(),
      this.canWorklist$,
      this.lastItems$.map(ii => ii.length > 0))
    .map(oks => oks.every(ii => ii));

  hasContent$ = Observable
    .combineLatest(this.hasContentPartners$, this.hasContentServices$, this.hasContentTens$, this.hasContentWorklist$)
    .map(oks => oks.some(ii => ii));

  ngOnDestroy() {
    [this.showPartners$, this.showServices$, this.showTens$, this.showWorklist$].forEach(ii => ii.complete());
  }

  gotoPartner = (id: string) => routing.gotoPartnerItem(this.router, id);
  gotoProcess = (id: number) => routing.gotoProcess(this.router, id);
  gotoTensItem = (id: DeliveryPointId) => routing.gotoTensItem(this.router, id);
  gotoWorkitem = (id: number) => routing.gotoWorkitem(this.router, id);

}

2 回答

  • 0

    您需要取消订阅每个订阅,例如在 ngOnDestroy() 方法中 .

    或者您可以'limit'使用 takeUntil()take()first() 等运算符的observable .

    以上规则也适用于 combineLatest .

    不要担心 AsyncPipe 创建的订阅,因为 AsyncPipe 本身负责取消订阅其自己的订阅 .

    关于这个主题的一个很好的读物是Ben Lesh的article,他是RxJS的领导者 .

  • 0

    好吧,我实际上只是使用.finally(...)测试它以及所有中间Observable的日志记录,并在组件被销毁时正确触发它 .

    因此,我宣布上述规则是正确的 .

相关问题