如何使用python修复匹配游戏中的int错误？

1 回答

• 0

  我解决了你的大部分问题 . 见内的评论 . 你的代码不被认为是“Pythonic”，但我已将大部分内容保留原样 .

  您可以改进对变量和方法名称的选择 . 例如，当迭代板的行和列时，使用 row 和 col 作为迭代变量 .

  此外， Card 类中的 getFace() 方法也许可以更好地重命名为 isFaceUp() ，或类似的效果 . 在这种情况下，取消与 False 的比较也将更自然地阅读 .

  另一个问题是你使用setter / getters . 正如其他人在评论中已经提出的那样，它们不被视为“Pythonic” .

  由于错误在不同的方法，一些基本的，似乎你试图一次写所有东西 . 一次编写/测试/调试一小段代码通常是个好主意 .

  #!/usr/bin/env python
  # -*- coding: utf-8 -*-
  
  from __future__ import print_function  # I'm using Python 2.7 so need this
  
  import random
  
  
  class Card(object):
      '''A card object with a suit and face'''
  
      def __init__(self, value):
          '''Stores both the card's value and face'''
          self._value = value
          self._face = False
  
      # Getters and setters are not Pythonic
      # Consider using property
      def getValue(self):
          '''Get the value of the card'''
          return self._value
  
      def getFace(self):
          '''Get the face of the card'''
          return self._face
  
      def setFace(self):
          self._face = True
  
      def __str__(self):
          '''Override str to return printable result. Useful for debugging.'''
          return ", ".join(("Value: ", str(self._value), "Face: ", str(self._face)))
  
  
  class Deck(object):
  
      def __init__(self, pairs):
          self._pairs = pairs
          self._cards = []
          for cards in range(self._pairs):
              c1 = Card(cards)
              self._cards.append(c1)
              c2 = Card(cards)
              self._cards.append(c2)
  
      def deal(self):
          if len(self) == 0:
             return None
          else:
             return self._cards.pop(0)
  
      def shuffle(self):
          '''Shuffles the cards.'''
          random.shuffle(self._cards)
  
      def __len__(self):
          '''Returns the number of cards in the deck'''
          return len(self._cards)
  
  
  class Game(object):
  
      def __init__(self, rows, columns):
          self._deck = Deck((rows * columns)//2)
          self._rows = rows
          self._columns = columns
          self._board = []
          for row in range(self._rows):
              self._board.append([0] * self._columns)
  
          self.populateBoard()
          # self.revealBoard()  # For debugging
  
  
      def populateBoard(self):
          self._deck.shuffle()
          # For debugging
          # print("Deck: {}".format(map(str, self._deck._cards)))
          # self._board = [[self._deck.deal() for _ in range(self._columns)]
          #                for _ in range(self._rows)]
  
          # Consider renaming variables as col and row. Similar for others
          # elsewhere
          for columns in range(self._columns):
              for rows in range(self._rows):
                  self._board[rows][columns] = self._deck.deal()
  
  
      def revealBoard(self):
          """For debugging. Reveal the cards for the board"""
          for rows in range(self._rows):
              for columns in range(self._columns):
                  print(str(self._board[rows][columns].getValue()) + " ", end="")
  
              print("")
  
  
      def displayBoard(self):
          for rows in range(self._rows):
              for columns in range(self._columns):
                  if self._board[rows][columns].getFace() == False:
                      print('* ', end="")
                  else:
                      # print(self._board[rows][columns._getValue()])
                      print(str(self._board[rows][columns].getValue()) + " ", end="")
  
              print("")  # Print newline after each row
  
  
      def play(self):
          while not self.isGameOver():
              self.displayBoard()
              coord1 = raw_input('Enter coordinates for the first card: ')
              coord2 = raw_input('Enter coordinates for the second card: ')
              newCoord1 = map(int, coord1.strip().split())
              newCard1 = self._board[newCoord1[0]][newCoord1[1]].getValue()
              newCoord2 = map(int, coord2.strip().split())
              newCard2 = self._board[newCoord2[0]][newCoord2[1]].getValue()
  
              # Need to check that user has entered valid data here
  
              # newCoord1 = coord1.split(" ")
              # newCard1 = self._board[int(newCoord1[0])][int(newCoord1[1])].getValue()
              # newCoord2 = coord2.split(" ")
              # newCard2 = self._board[int(newCoord2[0])][int(newCoord2[1])].getValue()
              if newCard1 != newCard2:
                  print("Not an identical pair. Found", newCard1, "at", newCoord1, "and", newCard2, "at", newCoord2)
              else:
                  self._board[newCoord1[0]][newCoord1[1]].setFace()
                  self._board[newCoord2[0]][newCoord2[1]].setFace()
                  # self._board[int(newCoord1[0])][int(newCoord1[1])].setFace()
                  # self._board[int(newCoord2[0])][int(newCoord2[1])].setFace()
  
          print("Game Over")
          self.displayBoard()
  
      def isGameOver(self):
          for rows in range(self._rows):
              if not all(card.getFace() for card in self._board[rows]):
                  return False
              # for columns in range(self._columns):
              #     # If there is still one card facing down then
              #     # game is not over yet
              #     if self._board[rows][columns].getFace() == False:
              #         return False
          return True
  
  
  def getUserInput(input_type):
      while True:
          try:
              val = int(raw_input("Enter number of {}: ".format(input_type)))
              if 1 <= val <= 9:
                  return val
              else:
                  raise ValueError
          except ValueError:
              print ("    ***Number of {} must be between 1 and 9! Try again.***".format(input_type))
  
  
  def main():
  
      while True:
          # Force user to enter valid value for number of rows and columns
          rows = getUserInput("rows")
          columns = getUserInput("cols")
  
          if rows * columns % 2 == 0:
              break
          else:
              print ("    ***The value of rows X columns must be even. Try again.***")
  
      game = Game(rows, columns)
      game.play()
  
  if __name__ == "__main__":
      main()
  

  回复于 2024-04-29T18:21:10+08:00